Skip to content

Support add the snapshot labels to images #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Support add the snapshot labels to images #1066

merged 2 commits into from
Nov 3, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented Oct 21, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

We use labels to filter the GCP images.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Add parameters to your VolumeSnapshotClass like so:

apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-gce-pd-snapshot-class
parameters:
  labels: cluster=preview,region=us,custom-label=awesome
  snapshot-type: images
driver: pd.csi.storage.gke.io
deletionPolicy: Delete

image

Does this PR introduce a user-facing change?:

Support setting snapshot labels to Images

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jenting!

It looks like this is your first PR to kubernetes-sigs/gcp-compute-persistent-disk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-compute-persistent-disk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jenting. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2022
@jenting jenting force-pushed the jenting/images-support-snapshot-labels branch from 2d3c5fd to f1d3b96 Compare October 21, 2022 08:44
@jenting jenting marked this pull request as ready for review October 21, 2022 09:01
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali October 21, 2022 09:01
@jenting
Copy link
Contributor Author

jenting commented Oct 22, 2022

@mattcary PTAL

@jenting
Copy link
Contributor Author

jenting commented Nov 2, 2022

/assign @mattcary

@mattcary
Copy link
Contributor

mattcary commented Nov 2, 2022

/ok-to-test

I'll take a look at this shortly, thanks for the ping.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 2, 2022
@mattcary
Copy link
Contributor

mattcary commented Nov 2, 2022

Ah, I didn't realize we just forgot to do the same with with disk image labels that we do with snapshots. Thanks for this change!

It looks like we already have unit tests in https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/pkg/common/parameters_test.go; can you add a sort-of-e2e test by adding labels to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/k8s-integration/config/image-volumesnapshotclass.yaml?

I don't think it will be easy to validate the labels are applied, but at least we'll catch if things will crash if they're used.

@jenting
Copy link
Contributor Author

jenting commented Nov 3, 2022

can you add a sort-of-e2e test by adding labels to https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/test/k8s-integration/config/image-volumesnapshotclass.yaml?

I added to pd-volumesnapshotclass.yaml and image-volumesnapshotclass.yaml.

@mattcary
Copy link
Contributor

mattcary commented Nov 3, 2022

Awesome, thanks again for your PR.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jenting, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 382229a into kubernetes-sigs:master Nov 3, 2022
@jenting jenting deleted the jenting/images-support-snapshot-labels branch November 3, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@mattcary mattcary Awaiting requested review from mattcary

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jenting @k8s-ci-robot @mattcary